PR updates

Author: stevenfontanella

src/passes/GlobalEffects.cpp

@@ -177,14 +177,10 @@ CallGraph buildCallGraph(const Module& module,
   for (HeapType type : allFunctionTypes) {
     // Not needed except that during lookup we expect the key to exist.
     callGraph[type];
-
-    for (auto super = type.getDeclaredSuperType(); super;
-         super = super->getDeclaredSuperType()) {
-      // Don't bother noting supertypes with no functions in it. There are no
-      // effects to aggregate anyway.
-      if (allFunctionTypes.contains(*super)) {
-        callGraph[*super].insert(type);
-      }
+    for (HeapType curr = type;
+         std::optional<HeapType> super = curr.getDeclaredSuperType();
+         curr = *super) {
+      callGraph[*super].insert(type);
     }
   }
 

test/lit/passes/global-effects-closed-world.wast

@@ -54,7 +54,8 @@
   ;; CHECK-NEXT:  )
   ;; CHECK-NEXT: )
   (func $g (param $ref (ref null $nopType))
-    ;; Similar to $f, but we may still trap here because the ref is null.
+    ;; Similar to $f, but we may still trap here because the ref is null, so we
+    ;; don't optimize.
     (call $calls-nop-via-nullable-ref (local.get $ref))
   )
 )