Skip to content

Commit 736fa9a

Browse files
committed
adapt to latest htmlunit
1 parent 7774f28 commit 736fa9a

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

src/main/java/org/openqa/selenium/htmlunit/HtmlUnitDriver.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
import org.htmlunit.html.FrameWindow;
7777
import org.htmlunit.html.HtmlElement;
7878
import org.htmlunit.html.HtmlPage;
79+
import org.htmlunit.javascript.HtmlUnitScriptable;
7980
import org.htmlunit.javascript.host.Element;
8081
import org.htmlunit.javascript.host.Location;
8182
import org.htmlunit.javascript.host.html.DocumentProxy;
@@ -875,17 +876,17 @@ public Object executeAsyncScript(final String script, Object... args) {
875876
}
876877

877878
private Object[] convertScriptArgs(final HtmlPage page, final Object[] args) {
878-
final Object scope = page.getEnclosingWindow().getScriptableObject();
879+
final HtmlUnitScriptable scope = page.getEnclosingWindow().getScriptableObject();
879880

880-
if (!(scope instanceof Scriptable)) {
881+
if (scope == null) {
881882
return args;
882883
}
883884

884885
final Object[] parameters = new Object[args.length];
885886
Context.enter();
886887
try {
887888
for (int i = 0; i < args.length; i++) {
888-
parameters[i] = parseArgumentIntoJavascriptParameter((Scriptable) scope, args[i]);
889+
parameters[i] = parseArgumentIntoJavascriptParameter(scope, args[i]);
889890
}
890891
}
891892
finally {

src/main/java/org/openqa/selenium/htmlunit/HtmlUnitWebElement.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828

2929
import org.htmlunit.ScriptResult;
3030
import org.htmlunit.corejs.javascript.ScriptRuntime;
31-
import org.htmlunit.corejs.javascript.Scriptable;
3231
import org.htmlunit.corejs.javascript.ScriptableObject;
3332
import org.htmlunit.html.DisabledElement;
3433
import org.htmlunit.html.DomElement;
@@ -383,9 +382,9 @@ public String getAttribute(final String name) {
383382
return "";
384383
}
385384

386-
final Object scriptable = element_.getScriptableObject();
387-
if (scriptable instanceof Scriptable) {
388-
final Object slotVal = ScriptableObject.getProperty((Scriptable) scriptable, name);
385+
final HtmlUnitScriptable scriptable = element_.getScriptableObject();
386+
if (scriptable != null) {
387+
final Object slotVal = ScriptableObject.getProperty(scriptable, name);
389388
if (slotVal instanceof String) {
390389
return (String) slotVal;
391390
}

0 commit comments

Comments
 (0)