Skip to content

Commit ca7b2d7

Browse files
author
merit\rembjo0
committed
Deprecate HttpRequest constructors without queryString
HTTP Redirect binding can fail if the queryString is ommited as URL encoding is non-canonical.
1 parent bc0b129 commit ca7b2d7

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

core/src/main/java/com/onelogin/saml2/http/HttpRequest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,9 @@ public final class HttpRequest {
3535
*
3636
* @param requestURL the request URL (up to but not including query parameters)
3737
* @throws NullPointerException if requestURL is null
38+
* @deprecated Not providing a queryString can cause HTTP Redirect binding to fail.
3839
*/
40+
@Deprecated
3941
public HttpRequest(String requestURL) {
4042
this(requestURL, EMPTY_PARAMETERS);
4143
}
@@ -56,7 +58,9 @@ public HttpRequest(String requestURL, String queryString) {
5658
* @param requestURL the request URL (up to but not including query parameters)
5759
* @param parameters the request query parameters
5860
* @throws NullPointerException if any of the parameters is null
61+
* @deprecated Not providing a queryString can cause HTTP Redirect binding to fail.
5962
*/
63+
@Deprecated
6064
public HttpRequest(String requestURL, Map<String, List<String>> parameters) {
6165
this(requestURL, parameters, null);
6266
}

0 commit comments

Comments
 (0)