[BUG] Breaking change in v7.17.0: missing RestApplication class

[chromey]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

v7.17.0 includes #22169 for the jaxrs-spec generator which "disable[s] generating RootResource and RootApplication if generating interfaces, since these files make no sense in the context of generating interface". However I would argue that they do, because while I am using interfaceOnly and providing my own API implementations, those could still take advantage of the @ApplicationPath annotation on the RestApplication class to provide a common base path for the @Path annotations on the interfaces. In fact, when this feature was originally introduced in #13377, a similar setup was explicitly discussed.

In v7.17.0 when using interfaceOnly, the context path is no longer prepended to resources (or even available for programmatic access), causing 404 errors.

openapi-generator version

v7.17.0

Steps to reproduce

1. Use jaxrs-spec generator with interfaceOnly=true
2. Generate code with v7.17.0
3. Try to use generated interfaces in RESTEasy Quarkus application
4. Observe 404 errors for endpoints

Related issues/PRs

• [BUG] Breaking change: @Path annotation no longer generated at class level when interfaceOnly=true in v7.17.0 #22279 addresses a similar regression caused by the same change, but this is its own thing

Suggest a fix

Either bring back RestApplication and RestResourceRoot, or provide an option to prepend the context path to the interfaces' @Path annotation.

[wing328]

thanks for the feedback.

cc @rignicat who is the author of #22169

[rignicat]

I think was reported in #22279 and fixed in #22316

Can you check and close if this is correct? or let me know if it isn't @chromey

[rupert-jung-mw]

Not sure if this is related but after updating 7.17.0 -> 7.18.0 my base path of URLs is also ignored for all REST calls against generated APIs, resulting in 404s for all calls. Might be a regression of this fix.

See #22631

After reverting back to 7.17.0 it worked again.

[chromey]

I think was reported in #22279 and fixed in #22316

Sorry for the late response @rignicat . No I think this is a separate issue. In fact 7.16, 7.17 and now 7.18 behave consistently for me in terms of @Path annotations on interfaces, and the issue introduced in 7.17 is not fixed in 7.18. Let me give you some more context to clarify:

For this OpenAPI spec:

openapi: 3.0.0
servers:
  - url: http://localhost:8080/api
paths:
  /persons:
    get:
      operationId: getPersons
  /persons/{id}:
    get:
      operationId: getPersonById

all three versions generate the same path annotations on the interface:

@Path("/persons")
public interface PersonsApi {

    @GET
    @Path("/{id}")
    Response getPersonById(@PathParam("id") UUID id);

    @GET
    Response getPersons();
}

What is different is that 7.16 also generated the following:

public class RestResourceRoot {
    public static final String APPLICATION_PATH = "/api";
}

@ApplicationPath(RestResourceRoot.APPLICATION_PATH)
public class RestApplication extends Application {

}

So now the Person resource is available at http://localhost:8080/persons rather than http://localhost:8080/api/persons