[BUG] [Java] [Spring Boot] Required path params not marked NotNull

[GregDThomas]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

Path parameters (which are required) are not marked @NotNull

openapi-generator version

7.15

OpenAPI declaration file content or url

You can see this in the samples.

openapi-generator/samples/server/petstore/springboot/src/main/java/org/openapitools/api/PetApi.java

Line 107 in bdfbb32

default ResponseEntity<Void> deletePet(

The operation is DELETE /pet/{petId} - but petId is not marked NotNull despite being required

@ApiParam(value = "Pet id to delete", required = true) @PathVariable("petId") Long petId,

[jpfinne]

The same behavior appears for all path params, even for GET, POST...

It looks like a feature.
See modules/openapi-generator/src/main/resources/JavaSpring/beanValidationPathParams.mustache

There is a comment: PathParam is always required, no @NotNull necessary

Indeed, the method is never called with a null arguments.

On the other hand, static analysis can give false alarm.

You can override beanValidationPathParams.mustache if you don't like it. Take beanValidationQueryParams.mustache as a sample, or add @NotNull unconditionally

[GregDThomas]

PathParam is always required, no @NotNull necessary

I tend to disagree with that comment. Like you say, static analysis will easily be tripped up. I intend to submit a PR to fix this shortly.

[wing328]

UPDATE: now enable via the option additionalNotNullAnnotations

related PR: #23096