Skip to content

Commit 74aa743

Browse files
committed
Fix whitespace in Swift oneOf templates
Remove extra blank line before public init(from decoder:) in generated oneOf Swift files by adjusting mustache tag placement.
1 parent 96b6a88 commit 74aa743

4 files changed

Lines changed: 10 additions & 20 deletions

File tree

modules/openapi-generator/src/main/resources/swift5/modelOneOf.mustache

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,15 @@
1919
{{/oneOfUnknownDefaultCase}}
2020
}
2121
}
22+
{{#discriminator}}
2223

23-
{{#discriminator}}
2424
private enum DiscriminatorCodingKey: String, CodingKey {
2525
case {{discriminator.propertyName}} = "{{discriminator.propertyBaseName}}"
2626
}
27-
{{/discriminator}}
27+
{{/discriminator}}
2828

2929
public init(from decoder: Decoder) throws {
30-
{{#discriminator}}
31-
let keyedContainer = try decoder.container(keyedBy: DiscriminatorCodingKey.self)
30+
{{#discriminator}} let keyedContainer = try decoder.container(keyedBy: DiscriminatorCodingKey.self)
3231
let discriminatorValue = try keyedContainer.decode(String.self, forKey: .{{discriminator.propertyName}})
3332

3433
switch discriminatorValue {
@@ -49,9 +48,7 @@
4948
)
5049
{{/oneOfUnknownDefaultCase}}
5150
}
52-
{{/discriminator}}
53-
{{^discriminator}}
54-
let container = try decoder.singleValueContainer()
51+
{{/discriminator}}{{^discriminator}} let container = try decoder.singleValueContainer()
5552
{{#oneOf}}
5653
{{#-first}}
5754
if let value = try? container.decode({{.}}.self) {
@@ -69,6 +66,5 @@
6966
throw DecodingError.typeMismatch(Self.Type.self, .init(codingPath: decoder.codingPath, debugDescription: "Unable to decode instance of {{classname}}"))
7067
{{/oneOfUnknownDefaultCase}}
7168
}
72-
{{/discriminator}}
73-
}
69+
{{/discriminator}} }
7470
}

modules/openapi-generator/src/main/resources/swift6/modelOneOf.mustache

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,15 @@
1919
{{/oneOfUnknownDefaultCase}}
2020
}
2121
}
22+
{{#discriminator}}
2223

23-
{{#discriminator}}
2424
private enum DiscriminatorCodingKey: String, CodingKey {
2525
case {{discriminator.propertyName}} = "{{discriminator.propertyBaseName}}"
2626
}
27-
{{/discriminator}}
27+
{{/discriminator}}
2828

2929
public init(from decoder: Decoder) throws {
30-
{{#discriminator}}
31-
let keyedContainer = try decoder.container(keyedBy: DiscriminatorCodingKey.self)
30+
{{#discriminator}} let keyedContainer = try decoder.container(keyedBy: DiscriminatorCodingKey.self)
3231
let discriminatorValue = try keyedContainer.decode(String.self, forKey: .{{discriminator.propertyName}})
3332

3433
switch discriminatorValue {
@@ -49,9 +48,7 @@
4948
)
5049
{{/oneOfUnknownDefaultCase}}
5150
}
52-
{{/discriminator}}
53-
{{^discriminator}}
54-
let container = try decoder.singleValueContainer()
51+
{{/discriminator}}{{^discriminator}} let container = try decoder.singleValueContainer()
5552
{{#oneOf}}
5653
{{#-first}}
5754
if let value = try? container.decode({{.}}.self) {
@@ -69,6 +66,5 @@
6966
throw DecodingError.typeMismatch(Self.Type.self, .init(codingPath: decoder.codingPath, debugDescription: "Unable to decode instance of {{classname}}"))
7067
{{/oneOfUnknownDefaultCase}}
7168
}
72-
{{/discriminator}}
73-
}
69+
{{/discriminator}} }
7470
}

samples/client/petstore/swift5/oneOf/PetstoreClient/Classes/OpenAPIs/Models/Fruit.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ public enum Fruit: Codable, JSONEncodable, Hashable {
2727
}
2828
}
2929

30-
3130
public init(from decoder: Decoder) throws {
3231
let container = try decoder.singleValueContainer()
3332
if let value = try? container.decode(Apple.self) {

samples/client/petstore/swift6/oneOf/PetstoreClient/Classes/OpenAPIs/Models/Fruit.swift

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ public enum Fruit: Sendable, Codable, ParameterConvertible, Hashable {
2424
}
2525
}
2626

27-
2827
public init(from decoder: Decoder) throws {
2928
let container = try decoder.singleValueContainer()
3029
if let value = try? container.decode(Apple.self) {

0 commit comments

Comments
 (0)