fix(typescript-nestjs): handle query params serialization properly (#20755)

mahmoudzeyada · web-flow · commit 21be5f5abce4 · 2025-03-10T16:07:21.000+01:00
* fix(typescript-nestjs): handle query params serialization properly

* fix(typescript-nestjs): updated the samples for param serialization fix
diff --git a/modules/openapi-generator/src/main/resources/typescript-nestjs/api.service.mustache b/modules/openapi-generator/src/main/resources/typescript-nestjs/api.service.mustache
@@ -137,7 +137,7 @@ export class {{classname}} {
             })
         {{/isCollectionFormatMulti}}
         {{^isCollectionFormatMulti}}
-            queryParameters['{{baseName}}'] = {{paramName}}.join(COLLECTION_FORMATS['{{collectionFormat}}']);
+            queryParameters.append('{{baseName}}', {{paramName}}.join(COLLECTION_FORMATS['{{collectionFormat}}']));
         {{/isCollectionFormatMulti}}
         }
         {{/isArray}}
diff --git a/samples/client/petstore/typescript-nestjs-v6-provided-in-root/builds/default/api/pet.service.ts b/samples/client/petstore/typescript-nestjs-v6-provided-in-root/builds/default/api/pet.service.ts
@@ -176,7 +176,7 @@ export class PetService {
 
         let queryParameters = new URLSearchParams();
         if (status) {
-            queryParameters['status'] = status.join(COLLECTION_FORMATS['csv']);
+            queryParameters.append('status', status.join(COLLECTION_FORMATS['csv']));
         }
 
         let headers = {...this.defaultHeaders};
@@ -236,7 +236,7 @@ export class PetService {
 
         let queryParameters = new URLSearchParams();
         if (tags) {
-            queryParameters['tags'] = tags.join(COLLECTION_FORMATS['csv']);
+            queryParameters.append('tags', tags.join(COLLECTION_FORMATS['csv']));
         }
 
         let headers = {...this.defaultHeaders};
diff --git a/samples/client/petstore/typescript-nestjs-v8-provided-in-root/builds/default/api/pet.service.ts b/samples/client/petstore/typescript-nestjs-v8-provided-in-root/builds/default/api/pet.service.ts
@@ -177,7 +177,7 @@ export class PetService {
 
         let queryParameters = new URLSearchParams();
         if (status) {
-            queryParameters['status'] = status.join(COLLECTION_FORMATS['csv']);
+            queryParameters.append('status', status.join(COLLECTION_FORMATS['csv']));
         }
 
         let headers = {...this.defaultHeaders};
@@ -237,7 +237,7 @@ export class PetService {
 
         let queryParameters = new URLSearchParams();
         if (tags) {
-            queryParameters['tags'] = tags.join(COLLECTION_FORMATS['csv']);
+            queryParameters.append('tags', tags.join(COLLECTION_FORMATS['csv']));
         }
 
         let headers = {...this.defaultHeaders};

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ export class {{classname}} {`
`137`	`137`	`})`
`138`	`138`	`{{/isCollectionFormatMulti}}`
`139`	`139`	`{{^isCollectionFormatMulti}}`
`140`		`- queryParameters['{{baseName}}'] = {{paramName}}.join(COLLECTION_FORMATS['{{collectionFormat}}']);`
	`140`	`+ queryParameters.append('{{baseName}}', {{paramName}}.join(COLLECTION_FORMATS['{{collectionFormat}}']));`
`141`	`141`	`{{/isCollectionFormatMulti}}`
`142`	`142`	`}`
`143`	`143`	`{{/isArray}}`
Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ export class PetService {`
`176`	`176`
`177`	`177`	`let queryParameters = new URLSearchParams();`
`178`	`178`	`if (status) {`
`179`		`- queryParameters['status'] = status.join(COLLECTION_FORMATS['csv']);`
	`179`	`+ queryParameters.append('status', status.join(COLLECTION_FORMATS['csv']));`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`let headers = {...this.defaultHeaders};`
`@@ -236,7 +236,7 @@ export class PetService {`
`236`	`236`
`237`	`237`	`let queryParameters = new URLSearchParams();`
`238`	`238`	`if (tags) {`
`239`		`- queryParameters['tags'] = tags.join(COLLECTION_FORMATS['csv']);`
	`239`	`+ queryParameters.append('tags', tags.join(COLLECTION_FORMATS['csv']));`
`240`	`240`	`}`
`241`	`241`
`242`	`242`	`let headers = {...this.defaultHeaders};`
Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ export class PetService {`
`177`	`177`
`178`	`178`	`let queryParameters = new URLSearchParams();`
`179`	`179`	`if (status) {`
`180`		`- queryParameters['status'] = status.join(COLLECTION_FORMATS['csv']);`
	`180`	`+ queryParameters.append('status', status.join(COLLECTION_FORMATS['csv']));`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`let headers = {...this.defaultHeaders};`
`@@ -237,7 +237,7 @@ export class PetService {`
`237`	`237`
`238`	`238`	`let queryParameters = new URLSearchParams();`
`239`	`239`	`if (tags) {`
`240`		`- queryParameters['tags'] = tags.join(COLLECTION_FORMATS['csv']);`
	`240`	`+ queryParameters.append('tags', tags.join(COLLECTION_FORMATS['csv']));`
`241`	`241`	`}`
`242`	`242`
`243`	`243`	`let headers = {...this.defaultHeaders};`