Skip to content

Commit 1acccd6

Browse files
committed
fix: return null instead of error message on deserialization failure
When deserializeErrorEntity fails, return null instead of a synthetic String message to maintain correct errorEntity semantics (null on failure). Fixes P2 issue from cubic-dev-ai review.
1 parent 3ec7cc4 commit 1acccd6

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

  • modules/openapi-generator/src/main/resources/Java/libraries/jersey3
  • samples/client/petstore/java/jersey3/src/main/java/org/openapitools/client

modules/openapi-generator/src/main/resources/Java/libraries/jersey3/ApiClient.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1369,7 +1369,7 @@ public class ApiClient{{#jsr310}} extends JavaTimeFormatter{{/jsr310}} {
13691369
try {
13701370
return deserialize(response, errorType);
13711371
} catch (Exception e) {
1372-
return String.format("Failed deserializing error entity: %s", e.toString());
1372+
return null;
13731373
}
13741374
}
13751375

samples/client/petstore/java/jersey3/src/main/java/org/openapitools/client/ApiClient.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1363,7 +1363,7 @@ private Object deserializeErrorEntity(Map<String, GenericType> errorTypes, Respo
13631363
try {
13641364
return deserialize(response, errorType);
13651365
} catch (Exception e) {
1366-
return String.format("Failed deserializing error entity: %s", e.toString());
1366+
return null;
13671367
}
13681368
}
13691369

0 commit comments

Comments
 (0)