fix style, explode, allowReserved defaults for parameter and encoding objects

- explode defaults were wrong for in: cookie, style: cookie, and for encoding object
- allowReserved defaults were wrong for encoding object

in parameter objects:
- explode: always false for "in: path", "in: header"
- explode: always true for "in: cookie" (both "style: form" and "style: cookie"
  default to "explode: true")
- explode: only true for "in: query" when "style: form" (the default style for
  this location)

in encoding objects:
- style: default is "form", but only when "explode" or "allowReserved" are present
- explode: default is true when "style: form" (the default style) and otherwise
  false, and not included at all unless "style" or "allowReserved" are present
- allowReserved: default is false, but only when "style" or "explode" are present

that is: when none of style, explode or allowReserved are present, "contentType"
is used (or a default is calculated), so none of style, explode or allowReserved
shall have default values

Author: karenetheridge

src/schemas/validation/schema.yaml

@@ -426,7 +426,6 @@ $defs:
           - $ref: '#/$defs/parameter/dependentSchemas/schema/$defs/styles-for-header'
           - $ref: '#/$defs/parameter/dependentSchemas/schema/$defs/styles-for-query'
           - $ref: '#/$defs/parameter/dependentSchemas/schema/$defs/styles-for-cookie'
-          - $ref: '#/$defs/styles-for-form'
 
         $defs:
           styles-for-path:
@@ -446,6 +445,8 @@ $defs:
                     - simple
                 required:
                   const: true
+                explode:
+                  default: false
                 allowReserved:
                   type: boolean
                   default: false
@@ -462,6 +463,8 @@ $defs:
                 style:
                   default: simple
                   const: simple
+                explode:
+                  default: false
 
           styles-for-query:
             if:
@@ -480,6 +483,7 @@ $defs:
                 allowReserved:
                   type: boolean
                   default: false
+              $ref: '#/$defs/explode-for-form'
 
           styles-for-cookie:
             if:
@@ -493,6 +497,8 @@ $defs:
                   enum:
                     - form
                     - cookie
+                explode:
+                  default: true
               if:
                 properties:
                   style:
@@ -610,7 +616,6 @@ $defs:
         type: boolean
       allowReserved:
         type: boolean
-        default: false
       encoding:
         type: object
         additionalProperties:
@@ -627,7 +632,10 @@ $defs:
           prefixEncoding: false
           itemEncoding: false
       style:
-        $ref: '#/$defs/styles-for-form'
+        properties:
+          allowReserved:
+            default: false
+        $ref: '#/$defs/explode-for-form'
       explode:
         properties:
           style:
@@ -638,7 +646,7 @@ $defs:
         properties:
           style:
             default: form
-        $ref: '#/$defs/styles-for-form'
+        $ref: '#/$defs/explode-for-form'
     $ref: '#/$defs/specification-extensions'
     unevaluatedProperties: false
 
@@ -1127,13 +1135,12 @@ $defs:
     additionalProperties:
       type: string
 
-  styles-for-form:
+  explode-for-form:
+    $comment: for encoding objects, and query and cookie parameters, style=form is the default
     if:
       properties:
         style:
           const: form
-      required:
-        - style
     then:
       properties:
         explode:

tests/schema/pass/parameter-object-examples.yaml

@@ -9,21 +9,23 @@ paths:
         in: header
         description: token to be passed as a header
         required: true
+        explode: false
         schema:
           type: array
           items:
             type: integer
             format: int64
         style: simple
-      - name: username
+      - name: usernames
         in: path
-        description: username to fetch
+        description: usernames to fetch
         required: true
+        explode: false
         schema:
-          type: string
+          type: array
       - name: id
         in: query
-        description: ID of the object to fetch
+        description: IDs of the object to fetch
         required: false
         schema:
           type: array
@@ -55,10 +57,12 @@ paths:
       - in: cookie
         name: my_cookie1
         style: form
+        explode: false
         schema: {}
       - in: cookie
         name: my_cookie2
         style: cookie
+        explode: true
         schema: {}
   /user:
     parameters: