allowReserved only permitted in encoding objects, and parameter objects with in:query

(this was changed in 3.2.0 to allow it wherever percent-encoding is done)

Author: karenetheridge

src/schemas/validation/schema.yaml

@@ -421,6 +421,7 @@ $defs:
                 style:
                   default: form
                   const: form
+              $ref: '#/$defs/explode-for-form'
 
     $ref: '#/$defs/specification-extensions'
     unevaluatedProperties: false
@@ -510,6 +511,7 @@ $defs:
         properties:
           allowReserved:
             default: false
+        $ref: '#/$defs/styles-for-form'
       explode:
         properties:
           style:
@@ -520,9 +522,8 @@ $defs:
         properties:
           style:
             default: form
-    allOf:
-      - $ref: '#/$defs/specification-extensions'
-      - $ref: '#/$defs/styles-for-form'
+        $ref: '#/$defs/styles-for-form'
+    $ref: '#/$defs/specification-extensions'
     unevaluatedProperties: false
 
   responses:

tests/schema/fail/header-object-allowReserved.yaml

@@ -0,0 +1,12 @@
+openapi: 3.1.0
+info:
+  title: "allowReserved only permitted with in: query"
+  version: 1.0.0
+components:
+  headers:
+    Style:
+      schema:
+        type: array
+      style: simple
+      explode: true
+      allowReserved: true

tests/schema/fail/parameter-object-cookie-form-allowReserved.yaml

@@ -0,0 +1,18 @@
+openapi: 3.1.0
+info:
+  title: allowReserved only permitted with in and style values that percent-encode
+  version: 1.0.0
+components:
+  parameters:
+    style_form:
+      name: my_form_cookie
+      in: cookie
+      # default style is form, therefore allowReserved is allowed
+      allowReserved: true
+      schema: {}
+    style_cookie:
+      name: my_cookie_cookie
+      in: cookie
+      style: cookie
+      # no percent decoding for style=cookie, therefore allowReserved is not allowed
+      schema: {}

tests/schema/fail/parameter-object-header-allowReserved.yaml

@@ -0,0 +1,11 @@
+openapi: 3.1.0
+info:
+  title: allowReserved only permitted with in and style values that percent-encode
+  version: 1.0.0
+components:
+  parameters:
+    header:
+      name: my-header
+      in: header
+      allowReserved: false
+      schema: {}

tests/schema/fail/parameter-object-path-allowReserved.yaml

@@ -0,0 +1,11 @@
+openapi: 3.1.0
+info:
+  title: "allowReserved only permitted with in: query"
+  version: 1.0.0
+components:
+  parameters:
+    path:
+      name: my-path
+      in: path
+      allowReserved: false
+      schema: {}

tests/schema/failparameter-object-path-allowReserved.yaml

@@ -0,0 +1,12 @@
+openapi: 3.1.0
+info:
+  title: api
+  version: 1.0.0
+components:
+  parameters:
+    path:
+      name: my-path
+      in: path
+      required: true
+      allowReserved: false
+      schema: {}

tests/schema/pass/header-object-examples.yaml

@@ -22,4 +22,4 @@ components:
       schema:
         type: array
       style: simple
-      explode: true
+      explode: true

tests/schema/pass/parameter-object-query-allowReserved.yaml

@@ -0,0 +1,11 @@
+openapi: 3.1.0
+info:
+  title: "allowReserved only permitted with in: query"
+  version: 1.0.0
+components:
+  parameters:
+    my_query:
+      name: my_query
+      in: query
+      allowReserved: true
+      schema: {}