Fix lexing name starting with numner

Only [a-zA-z] were considered a separator to the next token, missing were [__git_main].

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>

Author: MoonE

src/Lexer.php

@@ -842,7 +842,7 @@ public function parseNumber()
         // or "E" causing wrongly interpreted scientific notation (".e[0 to 9]" is invalid). Such invalid notation could
         // break the lexer when table names under a given database context starts with ".e[0-9]".
         //
-        // Valid final states are: 2, 3, 4 and 6. Any parsing that finished in a
+        // Valid final states are: 2, 3, 4, 6, and 9. Any parsing that finished in a
         // state other than these is invalid.
         // Also, negative states are invalid states.
         $iBak = $this->last;
@@ -886,29 +886,23 @@ public function parseNumber()
                     $state = 4;
                 } elseif ($this->str[$this->last] === 'e' || $this->str[$this->last] === 'E') {
                     $state = 5;
-                } elseif (
-                    ($this->str[$this->last] >= 'a' && $this->str[$this->last] <= 'z')
-                    || ($this->str[$this->last] >= 'A' && $this->str[$this->last] <= 'Z')
-                ) {
-                    // A number can't be directly followed by a letter
-                    $state = -$state;
-                    break;
                 } elseif ($this->str[$this->last] < '0' || $this->str[$this->last] > '9') {
+                    if  (! Context::isSeparator($this->str[$this->last])) {
+                        // A number can't be directly followed by a letter
+                        $state = -$state;
+                    }
                     // Just digits and `.`, `e` and `E` are valid characters.
                     break;
                 }
             } elseif ($state === 4) {
                 $flags |= Token::FLAG_NUMBER_FLOAT;
                 if ($this->str[$this->last] === 'e' || $this->str[$this->last] === 'E') {
                     $state = 5;
-                } elseif (
-                    ($this->str[$this->last] >= 'a' && $this->str[$this->last] <= 'z')
-                    || ($this->str[$this->last] >= 'A' && $this->str[$this->last] <= 'Z')
-                ) {
-                    // A number can't be directly followed by a letter
-                    $state = -$state;
-                    break;
                 } elseif ($this->str[$this->last] < '0' || $this->str[$this->last] > '9') {
+                    if (! Context::isSeparator($this->str[$this->last])) {
+                        // A number can't be directly followed by a letter
+                        $state = -$state;
+                    }
                     // Just digits, `e` and `E` are valid characters.
                     break;
                 }
@@ -919,10 +913,7 @@ public function parseNumber()
                     || ($this->str[$this->last] >= '0' && $this->str[$this->last] <= '9')
                 ) {
                     $state = 6;
-                } elseif (
-                    ($this->str[$this->last] >= 'a' && $this->str[$this->last] <= 'z')
-                    || ($this->str[$this->last] >= 'A' && $this->str[$this->last] <= 'Z')
-                ) {
+                } elseif (! Context::isSeparator($this->str[$this->last])) {
                     // A number can't be directly followed by a letter
                     $state = -$state;
                     break;

tests/data/lexer/lexNumberAtStartOfName.out

@@ -46,21 +46,12 @@
                 },
                 {
                     "@type": "PhpMyAdmin\\SqlParser\\Token",
-                    "token": "2",
-                    "value": 2,
-                    "keyword": null,
-                    "type": 6,
-                    "flags": 0,
-                    "position": 12
-                },
-                {
-                    "@type": "PhpMyAdmin\\SqlParser\\Token",
-                    "token": "_bar",
-                    "value": "_bar",
+                    "token": "2_bar",
+                    "value": "2_bar",
                     "keyword": null,
                     "type": 0,
                     "flags": 0,
-                    "position": 13
+                    "position": 12
                 },
                 {
                     "@type": "PhpMyAdmin\\SqlParser\\Token",
@@ -117,7 +108,7 @@
                     "position": null
                 }
             ],
-            "count": 12,
+            "count": 11,
             "idx": 0
         },
         "delimiter": ";",