fixes #390

Author: wumpz

README.md

@@ -43,6 +43,7 @@ Also I would like to know about needed examples or documentation stuff.
 
 ## Extensions in the latest SNAPSHOT version 0.9.7
 
+* Removed limitation of LongValue to accept only java.util.Long parsable values.
 * introduced NOT without parenthesis for column only conditions
 * introduced more complex expressions within CASE - statements
 * improved Postgresql JSON - support

src/main/java/net/sf/jsqlparser/expression/LongValue.java

@@ -21,55 +21,54 @@
  */
 package net.sf.jsqlparser.expression;
 
+import java.math.BigInteger;
+
 /**
- * Every number without a point or an exponential format is a LongValue
+ * Every number without a point or an exponential format is a LongValue.
  */
 public class LongValue implements Expression {
 
-	private long value;
-	private String stringValue;
+    private String stringValue;
+
+    public LongValue(final String value) {
+        String val = value;
+        if (val.charAt(0) == '+') {
+            val = val.substring(1);
+        }
+        this.stringValue = val;
+    }
 
-	public LongValue(final String value) {
-		String val = value;
-		if (val.charAt(0) == '+') {
-			val = val.substring(1);
-		}
-		try {
-		        this.value = Long.parseLong(val);
-		} catch (NumberFormatException e) {
-		        throw new NumberFormatException("Passed value does not contain a parsable long value");
-		}
-		this.stringValue = val;
-	}
-	
-	public LongValue(long value) {
-		this.value=value;
-		stringValue = String.valueOf(value);
-	}
+    public LongValue(long value) {
+        stringValue = String.valueOf(value);
+    }
 
-	@Override
-	public void accept(ExpressionVisitor expressionVisitor) {
-		expressionVisitor.visit(this);
-	}
+    @Override
+    public void accept(ExpressionVisitor expressionVisitor) {
+        expressionVisitor.visit(this);
+    }
 
-	public long getValue() {
-		return value;
-	}
+    public long getValue() {
+        return Long.valueOf(stringValue);
+    }
+    
+    public BigInteger getBigIntegerValue() {
+        return new BigInteger(stringValue);
+    }
 
-	public void setValue(long d) {
-		value = d;
-	}
+    public void setValue(long d) {
+        stringValue = String.valueOf(d);
+    }
 
-	public String getStringValue() {
-		return stringValue;
-	}
+    public String getStringValue() {
+        return stringValue;
+    }
 
-	public void setStringValue(String string) {
-		stringValue = string;
-	}
+    public void setStringValue(String string) {
+        stringValue = string;
+    }
 
-	@Override
-	public String toString() {
-		return getStringValue();
-	}
+    @Override
+    public String toString() {
+        return getStringValue();
+    }
 }

src/test/java/net/sf/jsqlparser/expression/LongValueTest.java

@@ -0,0 +1,77 @@
+/*
+ * Copyright (C) 2017 JSQLParser.
+ *
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
+ * MA 02110-1301  USA
+ */
+package net.sf.jsqlparser.expression;
+
+import java.math.BigInteger;
+import org.junit.After;
+import org.junit.AfterClass;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import static org.junit.Assert.*;
+
+/**
+ *
+ * @author tw
+ */
+public class LongValueTest {
+    
+    public LongValueTest() {
+    }
+    
+    @BeforeClass
+    public static void setUpClass() {
+    }
+    
+    @AfterClass
+    public static void tearDownClass() {
+    }
+    
+    @Before
+    public void setUp() {
+    }
+    
+    @After
+    public void tearDown() {
+    }
+
+    @Test
+    public void testSimpleNumber() {
+        LongValue value = new LongValue("123");
+        
+        assertEquals("123", value.getStringValue());
+        assertEquals(123L, value.getValue());
+        assertEquals(new BigInteger("123"), value.getBigIntegerValue());
+    }
+    
+    @Test
+    public void testLargeNumber() {
+        final String largeNumber = "20161114000000035001";
+        LongValue value = new LongValue(largeNumber);
+        
+        assertEquals(largeNumber, value.getStringValue());
+        try {
+            value.getValue();
+            fail("should not work");
+        } catch (Exception e) {
+            
+        }
+        assertEquals(new BigInteger(largeNumber), value.getBigIntegerValue());
+    }
+}

src/test/java/net/sf/jsqlparser/test/select/SelectTest.java

@@ -15,7 +15,6 @@
 import java.util.*;
 
 import static net.sf.jsqlparser.test.TestUtils.*;
-import net.sf.jsqlparser.util.TablesNamesFinder;
 
 public class SelectTest extends TestCase {
 
@@ -2440,4 +2439,8 @@ public void testProblemInNotInProblemIssue379() throws JSQLParserException {
         assertSqlCanBeParsedAndDeparsed("SELECT rank FROM DBObjects WHERE rank NOT IN (0, 1)");
         assertSqlCanBeParsedAndDeparsed("SELECT rank FROM DBObjects WHERE rank IN (0, 1)");
     }
+    
+    public void testProblemLargeNumbersIssue390() throws JSQLParserException {
+        assertSqlCanBeParsedAndDeparsed("SELECT * FROM student WHERE student_no = 20161114000000035001");
+    }
 }