fix: ignore all errors on getting the controls

Author: EmixamPP

src/video/ir/enabler.rs

@@ -81,11 +81,9 @@ impl Enabler {
     }
 
     /// Gets all the writable controls and not blacklisted controls from the device.
-    fn controls(&self) -> Result<Vec<XuControl>> {
-        let controls = self
-            .device
+    fn controls(&self) -> Vec<XuControl> {
+        self.device
             .controls()
-            .context("failed to get device controls")?
             .into_iter()
             .filter(|c| {
                 if c.writable() && !self.configuration.is_blacklisted(c) {
@@ -95,8 +93,7 @@ impl Enabler {
                     false
                 }
             })
-            .collect();
-        Ok(controls)
+            .collect()
     }
 
     /// Tries to find a configuration for the controls that enables the IR emitter(s).
@@ -108,7 +105,7 @@ impl Enabler {
             bail!("the IR emitter is already working");
         }
 
-        let mut controls = self.controls()?;
+        let mut controls = self.controls();
         self.send(Message::Controls(controls.clone())).await?;
 
         for ctrl in &mut controls {

src/video/uvc/device.rs

@@ -1,6 +1,6 @@
 use crate::video::uvc::XuControl;
 
-use std::io::{Error, ErrorKind, Result};
+use std::io::{Error, Result};
 use std::os::fd::AsFd;
 use std::path::{Path, PathBuf};
 
@@ -80,23 +80,19 @@ impl Device {
     }
 
     /// Tries to get all the control descriptions of the device.
-    ///
-    /// An empty list will be returned if the device has no controls.
-    pub fn controls(&self) -> Result<Vec<XuControl>> {
+    /// An empty list will be returned if the device no controls can be found
+    pub fn controls(&self) -> Vec<XuControl> {
         let mut controls = Vec::new();
         // Search for all possible combination of unit and selector
         for unit in 0..255 {
             for selector in 0..255 {
                 match self.find_control(unit, selector) {
                     Ok(control) => controls.push(control),
-                    Err(err) => match err.kind() {
-                        ErrorKind::NotFound | ErrorKind::PermissionDenied => {}
-                        _ => return Err(err),
-                    },
+                    Err(_) => {} // Ignore all errors
                 }
             }
         }
-        Ok(controls)
+        controls
     }
 
     /// Tries to apply the control to the device.
@@ -204,13 +200,8 @@ impl std::fmt::Display for Device {
                 .as_ref()
                 .map_or("unknown".into(), |p| p.display().to_string())
         )?;
-        match self.controls() {
-            Err(err) => writeln!(f, "   Failed to get the controls: {err:?}")?,
-            Ok(controls) => {
-                for control in controls {
-                    writeln!(f, "   {}", control)?;
-                }
-            }
+        for control in self.controls() {
+            writeln!(f, "   {}", control)?;
         }
         Ok(())
     }