Fix to Allow Spaces in Source View

thedillonb · thedillonb · commit eb9afd582293 · 2019-02-22T06:28:44.000-05:00
Fixes #517
diff --git a/CodeHub.iOS/ViewControllers/Source/FileSourceViewController.cs b/CodeHub.iOS/ViewControllers/Source/FileSourceViewController.cs
@@ -132,7 +132,7 @@ private async Task Load(CancellationToken cancelToken)
             if (Content == null)
             {
                 var encodedShaRef = System.Net.WebUtility.UrlEncode(_sha);
-                var encodedPath = _path == null ? null : System.Net.WebUtility.UrlEncode(_path);
+                var encodedPath = _path == null ? null : Uri.EscapeDataString(_path);
 
                 var items = await _applicationService
                     .GitHubClient.Repository.Content
diff --git a/CodeHub.iOS/ViewControllers/Source/SourceTreeViewController.cs b/CodeHub.iOS/ViewControllers/Source/SourceTreeViewController.cs
@@ -88,7 +88,7 @@ public SourceTreeViewController(
                         .GetAllContentsByRef(username, repository, encodedShaRef);
                 }
 
-                var encodedPath = path == null ? null : System.Net.WebUtility.UrlEncode(path);
+                var encodedPath = path == null ? null : Uri.EscapeDataString(path);
 
                 return await applicationService
                     .GitHubClient.Repository.Content

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ private async Task Load(CancellationToken cancelToken)`
`132`	`132`	`if (Content == null)`
`133`	`133`	`{`
`134`	`134`	`var encodedShaRef = System.Net.WebUtility.UrlEncode(_sha);`
`135`		`- var encodedPath = _path == null ? null : System.Net.WebUtility.UrlEncode(_path);`
	`135`	`+ var encodedPath = _path == null ? null : Uri.EscapeDataString(_path);`
`136`	`136`
`137`	`137`	`var items = await _applicationService`
`138`	`138`	`.GitHubClient.Repository.Content`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ public SourceTreeViewController(`
`88`	`88`	`.GetAllContentsByRef(username, repository, encodedShaRef);`
`89`	`89`	`}`
`90`	`90`
`91`		`- var encodedPath = path == null ? null : System.Net.WebUtility.UrlEncode(path);`
	`91`	`+ var encodedPath = path == null ? null : Uri.EscapeDataString(path);`
`92`	`92`
`93`	`93`	`return await applicationService`
`94`	`94`	`.GitHubClient.Repository.Content`